Skip to content

Add ide-assist: move_for_binder #20833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add ide-assist: move_for_binder #20833

wants to merge 1 commit into from

Conversation

@A4-Tacks
Copy link
Member

Move for-binder to where predicate.

Example

fn foo<F>()
where
    F: $0for<'a> Fn(&'a str)
{}

->

fn foo<F>()
where
    for<'a> F: Fn(&'a str)
{}

@A4-Tacks
Add ide-assist: move_for_binder
a10145f 
Move for-binder to where predicate.

Example
---
```rust
fn foo<F>()
where
    F: $0for<'a> Fn(&'a str)
{}
```
->
```rust
fn foo<F>()
where
    for<'a> F: Fn(&'a str)
{}
```
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 12, 2025
Veykril
Veykril reviewed Oct 26, 2025
View reviewed changes
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fairly niche to me, I'm not sure we need an assist for this. We already have quite a lot of assists at this point.

@A4-Tacks
Copy link
Member Author

This seems fairly niche to me

This is indeed fairly niche

@A4-Tacks A4-Tacks closed this Oct 26, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 26, 2025
@A4-Tacks A4-Tacks deleted the move-for-binder branch October 26, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Veykril Veykril Veykril left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@A4-Tacks @Veykril @rustbot